Re: password API needed

Jeremy Allison (jallison@whistle.com)
Mon, 18 May 1998 11:56:30 -0700

Date:	Mon, 18 May 1998 11:56:30 -0700
From:	Jeremy Allison <jallison@whistle.com>
To:	Luke Kenneth Casson Leighton <lkcl@switchboard.net>
Subject: Re: password API needed

Luke,

I am looking through what you have done in
passdb.c etc. You have confused functions that return
smb_passwd entries and funtions that return sam_passwd
entries.

As an example :

You now have

getsampwnam and getsampwuid returning a struct smb_passwd.

This makes no sense - if they return a smb_passwd
they should be called getsmbpwnam and getsmbpwuid (as they
were originally).

You then have getsam21pwnam returning a struct sam_passwd.
This is ok.

You need to make explicit in the function name
what it will return.

This means that (to stick to your current naming
structure) anything returning a sam_passwd struct
should be called get/setsam21XXXX(), to make it
clear it's returning something different from a
smb_passwd.

All functions returning an smb_passwd must be
called get/setsmbXXXXX.

I will make these changes, as it will clarify a
great deal of code.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------