Re: CVS update: samba/source

Christopher R. Hertel (crh@NTS.Umn.EDU)
Thu, 9 Apr 1998 02:54:25 -0500 (CDT)

From:	"Christopher R. Hertel" <crh@NTS.Umn.EDU>
Message-Id: <199804090754.CAA09402@unet.unet.umn.edu>
Subject: Re: CVS update: samba/source
To:	jallison@whistle.com (Jeremy Allison)
Date:	Thu, 9 Apr 1998 02:54:25 -0500 (CDT)
In-Reply-To: <352C35B6.446B9B3D@whistle.com> from "Jeremy Allison" at Apr 8, 98 07:43:02 pm

Jeremy,

The problem is in ubi_Cache.c, where I have:

static char ModuleID[] =
"ubi_Cache\n\
\t$Revision: 0.0 $\n\
\t$Date: 1997/12/18 06:24:33 $\n\
\t$Author: crh $\n";

In ubi_BinTree.c I have a function which prints these out. I need to
write a similar function for ubi_Cache.c, but it had occurred to me that
it was silly to write the same function in every module. I hadn't had
time to come up with a new way of doing this, so I just left the string
in ubi_Cache. A warning is valid, but the -Werror turns warnings into
errors.

Honestly, I don't know how you compile at all. I get *lots* of warnings
when I compile on the SGI.

Anyway, I'd prefer to just leave it as it is. It's all a matter of
deciding where the problem lives. From your point of view, it's in my
code, but in my point of view... Well, I do take warnings seriously but
if I know why they're there I typically let them go. They serve to
remind me of future enhancements.

You could compile the ubiqx modules first (without -Werror) and then
compile the rest as you like.

Let me know if you really can't bring yourself to let this one go.

Chris -)-----

>
> Chris,
>
> I'm getting errors after doing the make proto
> (I added the grep -v ubiqx to my temporary Makefile
> to get rid of them) - but now I'm getting (with
> gcc -Wall -Werror, which is my default compile
> setting):
>
> Compiling ubiqx/ubi_Cache.c
> cc1: warnings being treated as errors
> ubiqx/ubi_Cache.c:107: warning: `ModuleID' defined but not used
> *** Error code 1
>
> Looking into this it seems to be a module
> identifier. Can you fix this please (I always
> make sure things compile with -Wall -Werror,
> to keep me 'clean' :-).
>
> I have a NIS+ patch pending to go into the
> main branch, that's why I'm hassling you
> right now :-) (I already added it to the 1.9.18
> branch).
>
> Cheers,
>
> Jeremy.
>
> --
> --------------------------------------------------------
> Buying an operating system without source is like buying
> a self-assembly Space Shuttle with no instructions.
> --------------------------------------------------------
>

-- 
Christopher R. Hertel -)-----                   University of Minnesota
crh@nts.umn.edu              Networking and Telecommunications Services