Re: code for 1.9.19alphas

Christopher R. Hertel (crh@NTS.Umn.EDU)
Thu, 16 Apr 1998 11:16:57 -0500 (CDT)

From:	"Christopher R. Hertel" <crh@NTS.Umn.EDU>
Message-Id: <199804161616.LAA10839@unet.unet.umn.edu>
Subject: Re: code for 1.9.19alphas
To:	lkcl@regent.push.net
Date:	Thu, 16 Apr 1998 11:16:57 -0500 (CDT)
In-Reply-To: <Pine.LNX.3.96.980416130746.11771T-100000@regent.push.net> from "Luke Kenneth Casson Leighton" at Apr 16, 98 11:17:14 pm

Ooops. Fingers slipped.

What I meant to say was...

>
> ok, further comments (this is posted to samba-technical, too).
>
> instead of a separate free_xxx function, add an extra BOOL parameter to
> make_xxxx.
>
> if True, malloc. if False, free. call other make_xxxx sub-functions with
> the extra BOOL parameter too.

Eeeuuwww. Yech. Nasty.

> reason: this will keep mallocs and frees in the same place. this is
> important so that future development doesn't get out of step (resulting in
> loss of memory stuff).

Mallocs and frees should be in the same file, but as complimentary
calls. Okay, this is *principle*, and practice sometimes strays, but
it's generally a bad idea to overload a single function. A function
should perform *a function*.

Chris -)-----

-- 
Christopher R. Hertel -)-----                   University of Minnesota
crh@nts.umn.edu              Networking and Telecommunications Services